Add deployment helm chart. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/helm-chart
branch
7 times, most recently
from
40dee09 to
a2d5ca5
Compare
vincentsarago
approved these changes
Feb 10, 2025
emmanuelmathot
requested changes
Feb 10, 2025
pantierra
force-pushed
the
feature/helm-chart
branch
2 times, most recently
from
0665f28 to
5180a2a
Compare
pantierra
force-pushed
the
feature/helm-chart
branch
from
5180a2a to
9b52658
Compare
|
Many thanks for your reviews! I suggest to add the version check in a second step and move these charts in first. |
emmanuelmathot
approved these changes
Feb 11, 2025
|
Thanks again. Here is the promised follow-up draft PR for the version checks: #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a helm chart and basic instructions to deploy it on a (local) kubernetes cluster.
Related to: #33