Fix bug that occurs with dataclass_json 0.62 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i guess a release makes sense also from the point that eo-grow tests get fixed. Otherwise we have to skip the byoc pipeline tests for a bit. |
mlubej
approved these changes
Nov 13, 2023
Comment on lines
161
to
165
| if len(bbox) == 4: | ||
| min_x, min_y, max_x, max_y = cast(Tuple[float, float, float, float], bbox) | ||
| min_x, min_y, max_x, max_y = bbox | ||
| else: | ||
| (min_x, min_y), (max_x, max_y) = cast(Tuple[Tuple[float, float], Tuple[float, float]], bbox) | ||
| (min_x, min_y), (max_x, max_y) = bbox | ||
| return float(min_x), float(min_y), float(max_x), float(max_y) |
There was a problem hiding this comment.
Would it make sense to limit the various options how to define a bbox? it seems like a similar situation as in case of features in eolearn. But this is a separate issue, so this is just a comment.
There was a problem hiding this comment.
we already did quite a bit
the problem with that is that it is fairly code-breaking, so it's a sin of the past that we're slowly correcting
zigaLuksic
added a commit
that referenced
this pull request
Nov 13, 2023
* Enable Github actions to trigger internal Gitlab CI (#490) * update actions and gitlab CI * update project path * use trigger API to build internal docker instead * test trigger on branch push * fix github action * test why trigger workflow not starting * fix branch name * remove step in trigger job * remove test branch * move mirror to a separate workflow, update pipeline running rules * Revert "move mirror to a separate workflow, update pipeline running rules" This reverts commit 92b4b04. --------- Co-authored-by: Matic Lubej <[email protected]> * deprecate deprecation wrappers * switch to type_extensions deprecations * add comments * Fix bug that occurs with dataclass_json 0.62 (#493) * remove "undefined" catch-all flag from a field * mypy fixes * fix wrong import * remove redundant import --------- Co-authored-by: Matic Lubej <[email protected]> Co-authored-by: Matic Lubej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue happens when someone calls the
to_dictmethod on the collection.Sadly this is used in our code a lot 🙃 would you consider this worthy of a release?