Hot reload for components and importmap #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squrious
force-pushed
the
better_hmr
branch
2 times, most recently
from
e90f3f2 to
912b569
Compare
WebMamba
approved these changes
Jan 9, 2024
src/Command/DumpImportMapCommand.php
Outdated
| /** | ||
| * @author Nicolas Rigaud <[email protected]> | ||
| */ | ||
| class DumpImportMapCommand extends Command |
There was a problem hiding this comment.
Elle apporte quoi cette commande par rapport à un php bin/console debug:asset-map ?
There was a problem hiding this comment.
C'est pas une commande de debug, ça permet de générer le module JS pour l'importmap. Je vais documenter en commentaires pour être plus explicite. Peut-être aussi changer le nom ?
|
En suivant t'as doc j'ai eu une erreur: SB_CORE-SERVER_0002 (CriticalPresetLoadError): Storybook failed to load the following preset: @storybook/symfony-webpack5/preset.
Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.
If you believe this is a bug, please open an issue on Github.
Error: Cannot find module 'fast-xml-parser'
Require stack:
- /Users/matheodaninos/Project/contributing/StorybookBundle/storybook/dist/preset.js
- ./node_modules/@storybook/core-common/dist/index.js
- ./node_modules/@storybook/telemetry/dist/index.js
- ./node_modules/@storybook/cli/dist/generate.js
- ./node_modules/@storybook/cli/bin/index.js
- ./node_modules/storybook/index.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
at Module._load (node:internal/modules/cjs/loader:922:27)
at Module.require (node:internal/modules/cjs/loader:1143:19)
at require (node:internal/modules/cjs/helpers:119:18)
at Object.<anonymous> (/Users/matheodaninos/Project/contributing/StorybookBundle/storybook/dist/preset.js:10:21)
at Module._compile (node:internal/modules/cjs/loader:1256:14)
at Module._compile (./node_modules/esbuild-register/dist/node.js:2258:26)
at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
at Object.newLoader (./node_modules/esbuild-register/dist/node.js:2262:9)
at extensions..js (./node_modules/esbuild-register/dist/node.js:4838:24)
at loadPreset (./node_modules/@storybook/core-common/dist/index.js:15:82)
|
squrious
force-pushed
the
better_hmr
branch
2 times, most recently
from
31bc17d to
0541acd
Compare
squrious
force-pushed
the
better_hmr
branch
3 times, most recently
from
2666d12 to
411a263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hot reload for Twig Components by loading templates as JS dependencies of stories modules.
Add hot reload for AssetMapper assets by generating a virtual importmap module.
Add tests for PHP and JS source codes.