Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding domains related method documentation #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gregory-Gerard
Copy link

@Gregory-Gerard Gregory-Gerard commented Sep 10, 2022

Fixes

Small PR for adding domains related method documentation, to help our IDE with these endpoints (https://docs.sendgrid.com/api-reference/domain-authentication/list-all-authenticated-domains for example). No code changes, just PHPDoc.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@Kingdutch
Copy link

Looks like 1.5 years later this info is unfortunately still missing which makes these kinds of tasks more difficult. @SendGridDX What would be needed to get this PR merged? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants