Fix cannot enter small decimals in breakpoint table #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:senaite/senaite.ast into fix-smaller-decimals
ramonski
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request patches
z3c.form.converter.NumberDataConverterto prevent the error "The entered value is not a valid decimal literal" that arises when entering small decimal values like0.0625into breakpoint table:Another (and maybe better) approach could be any of these:
schema.Floatand useschema.TextLine(with their counterpart validators)IDataConverteradapter forschema.Floatto take these cases into account (preferred).See
plone.schema.browser.jsonfieldfor hints.Current behavior before PR
Is not possible to enter small decimals in breakpoint table.
Desired behavior after PR is merged
Is possible to enter small decimals in breakpoint table.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.