Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC 1.1.5 #99

Closed
wants to merge 4 commits into from
Closed

RC 1.1.5 #99

wants to merge 4 commits into from

Conversation

semuadmin
Copy link
Contributor

pygnssutils Pull Request Template

Description

  1. Streamline gnssntripclient and improve exit handling when invoked via PyGPSClient.

Fixes #98

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the bug Something isn't working label Oct 28, 2024
@semuadmin semuadmin added this to the RC 1.1.5 milestone Oct 28, 2024
@semuadmin semuadmin self-assigned this Oct 28, 2024
@semuadmin semuadmin requested a review from a team October 28, 2024 21:57
@semuadmin semuadmin marked this pull request as draft October 28, 2024 21:57
@semuadmin semuadmin added the enhancement New feature or request label Oct 30, 2024
@semuadmin semuadmin closed this Oct 30, 2024
@semuadmin semuadmin deleted the RC-1.1.5 branch October 30, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTRIP socket persists after stop
1 participant