Skip to content

Support java executable in path #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Support java executable in path #1215

wants to merge 2 commits into from

Conversation

Jamie-SA
Copy link
Contributor

@Jamie-SA Jamie-SA commented Apr 25, 2025 •
edited
Loading

Fixes #1214

I changed the pre-commit to:

  • Prefer RDF_TOOLKIT_JAVA_HOME over JAVA_HOME, since it is the more specific name.
  • If neither of those work, use a java executable if one is available in the PATH.
  • Removed some trailing spaces.

sa-bpelakh
sa-bpelakh approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@sa-bpelakh sa-bpelakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I even learned that you can do $var=${var/<find>/<replace>/}, which I have never seen before. Very cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sa-bpelakh sa-bpelakh sa-bpelakh approved these changes

@pwin pwin Awaiting requested review from pwin

@rjyounes rjyounes Awaiting requested review from rjyounes

@coltonglasgow coltonglasgow Awaiting requested review from coltonglasgow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The serializer pre-commit doesn't work if your java app is not in a "bin/" directory
2 participants
@Jamie-SA @sa-bpelakh