fix: add support for repository suffix and add "/-" as GitLab repo suffix #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doteric
commented
May 24, 2023
| @@ -41,7 +41,7 @@ export async function generateNotes(pluginConfig, context) { | |||
| protocol = protocol && /http[^s]/.test(protocol) ? "http" : "https"; | |||
| const [, owner, repository] = /^\/(?<owner>[^/]+)?\/?(?<repository>.+)?$/.exec(pathname); | |||
|
|
|||
| const { issue, commit, referenceActions, issuePrefixes } = | |||
| const { issue, commit, referenceActions, issuePrefixes, repositoryPathSuffix } = | |||
There was a problem hiding this comment.
Suggested change
| const { issue, commit, referenceActions, issuePrefixes, repositoryPathSuffix } = | |
| const { issue, commit, referenceActions, issuePrefixes, repositoryPathSuffix = "" } = |
I could also default to an empty string if you'd like and just do
repository:`${repository}${repositoryPathSuffix}`,
Whatever is preferred ;D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the #449 issue.
@travi , please let me know is this an acceptable way to handle this or you would prefer some other way. I found it not really convenient for any other approach + TypeScript would help a lot in the future 😁
Anything else would require work inside
conventional-changelog-writerand also possibly in every changelog template. For example conventional-changelog-eslint has...{{@root.repository}}/compare/{{previousTag}}...{{currentTag}}...