Fixed print issue #36
Conversation
lib/print.js
Outdated
| // contains a div/mul operation | ||
| // e.g x^((x + 1)/(2 + 2)) | ||
| if (exponent.args){ | ||
| if (exponent.op == 'div' || exponent.op == 'mul'){ |
There was a problem hiding this comment.
There should be a space between conditionals the opening brace. See #37. It can't be handled in a separate diff.
There was a problem hiding this comment.
I think you could probably add that to the linter
lib/print.js
Outdated
| bool = true; | ||
| } | ||
| } | ||
| if (bool) { |
There was a problem hiding this comment.
Can you change this to if (isMul(exponent) || isDiv(exponent) { and define those helper functions as necessary. Then you can get rid of the comment above b/c the intent is clear from the code.
package.json
Outdated
| @@ -25,6 +25,8 @@ | |||
| "babel-plugin-transform-object-rest-spread": "^6.22.0", | |||
| "babel-preset-es2015": "^6.22.0", | |||
| "eslint": "^3.15.0", | |||
| "eslint-config-google": "^0.7.0", | |||
| "eslint-plugin-sort-requires": "^2.1.0", | |||
There was a problem hiding this comment.
Please leave this out. I'm open to changing lint set up for this repo but we should discuss it first and do it in a separate PR.
.eslintrc
Outdated
| "node": true, | ||
| "mocha": true | ||
| } | ||
| } |
There was a problem hiding this comment.
This was there before the diff and shouldn't be removed.
package.json
Outdated
| @@ -24,8 +24,6 @@ | |||
| "babel-plugin-transform-flow-strip-types": "^6.22.0", | |||
| "babel-plugin-transform-object-rest-spread": "^6.22.0", | |||
| "babel-preset-es2015": "^6.22.0", | |||
| "eslint": "^3.15.0", | |||
| "eslint-plugin-flowtype": "^2.30.0", | |||
There was a problem hiding this comment.
This shouldn't have been removed either.
|
@aliang8 one last change before this can be merged – please revert changes to package.json. |
|
@aliang8 for an easy way to revert files to a previous commit see http://stackoverflow.com/questions/215718/reset-or-revert-a-specific-file-to-a-specific-revision-using-git. |
|
Looks good. Thanks for fixing this. |
Fixed print to display parentheses around exponents. Added appropriate test cases.