Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a GoAccess template #466

Merged
merged 10 commits into from
May 22, 2024
Merged

Conversation

bravohotel91
Copy link
Contributor

@bravohotel91 bravohotel91 commented Jan 29, 2024

Created a GoAccess template in response to Issue #306

Closes #306

@bravohotel91 bravohotel91 marked this pull request as ready for review January 29, 2024 16:50
@nwithan8
Copy link
Member

nwithan8 commented Jan 29, 2024

There is an existing template, but it looks like it's someone who made their own container that simply builds the original application from source: https://unraid.net/community/apps?q=goaccess#r

It's several years out of date, so I'm fine with introducing a more up-to-date template that will actually use the original Docker image.

templates/goaccess.xml Outdated Show resolved Hide resolved
templates/goaccess.xml Outdated Show resolved Hide resolved
templates/goaccess.xml Outdated Show resolved Hide resolved
@bravohotel91
Copy link
Contributor Author

@nwithan8 - I appreciate the check. I was initially going to comment and state that there were already some out there, but they are all not using the official container of the project and out-of-date.

@nwithan8 nwithan8 requested a review from Roxedus January 29, 2024 17:29
Copy link
Member

@nwithan8 nwithan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an icon and point to it in the template.

nwithan8
nwithan8 previously approved these changes Jan 29, 2024
templates/goaccess.xml Outdated Show resolved Hide resolved
templates/goaccess.xml Show resolved Hide resolved
@nwithan8 nwithan8 dismissed their stale review May 21, 2024 17:28

Changes needed

@bravohotel91
Copy link
Contributor Author

@nwithan8 changes made to add port mapping

@nwithan8
Copy link
Member

Had to rebase to fix the CI linter

@nwithan8 nwithan8 merged commit 3b16eb2 into selfhosters:master May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA Template Request - GoAccess
3 participants