Fix log message on exception in UC Reactor#2105
Merged
mdmintz merged 1 commit intoseleniumbase:masterfrom Sep 13, 2023
jdholtz:fix-uc-logging
Merged
Fix log message on exception in UC Reactor#2105mdmintz merged 1 commit intoseleniumbase:masterfrom jdholtz:fix-uc-logging
mdmintz merged 1 commit intoseleniumbase:masterfrom
jdholtz:fix-uc-logging
Conversation
First, the exception didn't have a placeholder which caused a logging exception. Also, logging.debug was called instead of logger.debug. This had a side effect that all the debug messages after that would print to the console, even when they didn't before.
Member
|
It works. Merged. Thank you. |
Member
|
It'll be part of the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug took me a while to find, but the main problem it had is that it caused all my logging messages to print with the root logger in the program I use seleniumbase in. I included some code below that will show you the issue.