Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 and 8.2 version tests #15

Merged

Conversation

peter279k
Copy link
Member

Changed log

  • Adding the PHP 8.1 and PHP 8.2 versions test in the GitHub workflows.

@peter279k
Copy link
Member Author

It seems that it will be failed when running the composer cs:check with the PHP 8.0 version.

It will be successful when running the composer cs:check with the PHP 8.1+ versions.

When running the cs:check command with the PHP 8.0 version, the result messages are as follows:

localadmin@clickhouse02:~/basepath$ php -v
PHP 8.1.23 (cli) (built: Sep  2 2023 06:58:52) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.23, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.23, Copyright (c), by Zend Technologies
localadmin@clickhouse02:~/basepath$ php ~/composer.phar cs:check
> php-cs-fixer fix --dry-run --format=txt --verbose --diff --config=.cs.php
PHP CS Fixer 3.25.1 Crank Cake by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.1.23
Loaded config default from ".cs.php".
......                                                                                6 / 6 (100%)
Legend: .-no changes, F-fixed, S-skipped (cached or empty file), I-invalid file syntax (file ignored), E-error

Found 0 of 6 files that can be fixed in 0.267 seconds, 14.000 MB memory used

When running the cs:check command with the PHP 8.1 version, the result messages are as follows:

localadmin@clickhouse02:~/basepath$ php -v
PHP 8.0.30 (cli) (built: Sep  2 2023 08:04:32) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.30, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.30, Copyright (c), by Zend Technologies
localadmin@clickhouse02:~/basepath$
localadmin@clickhouse02:~/basepath$
localadmin@clickhouse02:~/basepath$ php ~/composer.phar cs:check
> php-cs-fixer fix --dry-run --format=txt --verbose --diff --config=.cs.php
PHP Parse error:  syntax error, unexpected token ")" in /home/localadmin/basepath/vendor/symfony/event-dispatcher/EventDispatcher.php on line 260
Script php-cs-fixer fix --dry-run --format=txt --verbose --diff --config=.cs.php handling the cs:check event returned with error code 255
localadmin@clickhouse02:~/basepath$

@peter279k
Copy link
Member Author

When I found the commit, it seems that the better way is to remove the PHP 8.0 test in the GitHub action workflow.

run: composer update --prefer-dist --no-progress

- name: Install dependencies for PHP 8
if: matrix.php-versions >= '8.0'
run: composer update --prefer-dist --no-progress --ignore-platform-reqs
Copy link
Member Author

@peter279k peter279k Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, I found current solution about the composer update commands.

And it refers the build.yml file

@odan odan merged commit 23cc8a9 into selective-php:master Sep 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants