Protect against internal instance variables without accessors #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 19, 2014 10:49
…essors. Not all instance variables have accessors so be defensive. At this point if you are looking to preserve a state you should have an attr_accessor for it.
Be clear about what is stored and recovered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an object that had an instance variable that came in at runtime via another gem. No getters / setters as it was not one of the values I cared about preserving. However the system would explode trying to fetch and restore the state of this variable.
Changes will ensure the getter / setter methods exist before we try to call them. It does let variable state drop away though so have made a slight change to the readme to express this. I feel it's valid that you ensure there are accessors for the variable states you want to preserve.
Longer term maybe look at instance variable get / set directly if it's worth pursuing full variable state preservation.