Updated RemoteDeviceList and PfRingDeviceList's getDevice API to match the rest.
#1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimi1010
added
refactoring
API deprecation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1810 +/- ##
==========================================
- Coverage 83.08% 83.05% -0.03%
==========================================
Files 284 284
Lines 48981 48996 +15
Branches 10305 10542 +237
==========================================
Hits 40694 40694
+ Misses 7501 7161 -340
- Partials 786 1141 +355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tigercosmos
approved these changes
May 8, 2025
seladb
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the get device functions to the convention
getDeviceBy***instead of theget***DeviceBy***to match the rest of the lists (LiveDevice, Dpdk, Kni). It also deprecates all the old get device methods.