Skip to content

Commit

Permalink
fix(objectnode): fix superfluous writeheader
Browse files Browse the repository at this point in the history
Signed-off-by: tangdeyi <[email protected]>
  • Loading branch information
tangdeyi committed Aug 31, 2023
1 parent 14f0f67 commit b24525a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions objectnode/api_handler_object.go
Original file line number Diff line number Diff line change
Expand Up @@ -651,13 +651,13 @@ func (o *ObjectNode) deleteObjectsHandler(w http.ResponseWriter, r *http.Request
if err = rateLimit.AcquireLimitResource(vol.owner, DELETE_OBJECT); err != nil {
return
}
if err = vol.DeletePath(object.Key); err != nil {
if err1 := vol.DeletePath(object.Key); err1 != nil {
log.LogErrorf("deleteObjectsHandler: delete object failed: requestID(%v) volume(%v) path(%v) err(%v)",
GetRequestID(r), vol.Name(), object.Key, err)
if err != AccessDenied {
deletedErrors = append(deletedErrors, Error{Key: object.Key, Code: "InternalError", Message: err.Error()})
GetRequestID(r), vol.Name(), object.Key, err1)
if err1 != AccessDenied {
deletedErrors = append(deletedErrors, Error{Key: object.Key, Code: "InternalError", Message: err1.Error()})
} else {
deletedErrors = append(deletedErrors, Error{Key: object.Key, Code: "AccessDenied", Message: err.Error()})
deletedErrors = append(deletedErrors, Error{Key: object.Key, Code: "AccessDenied", Message: err1.Error()})
}
} else {
log.LogDebugf("deleteObjectsHandler: delete object success: requestID(%v) volume(%v) path(%v)",
Expand Down
4 changes: 2 additions & 2 deletions objectnode/fs_volume.go
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ func (v *Volume) DeletePath(path string) (err error) {
return
}
}
log.LogWarnf("DeletePath: delete: volume(%v) path(%v) inode(%v)", v.name, path, ino)
log.LogInfof("DeletePath: delete: volume(%v) path(%v) inode(%v)", v.name, path, ino)

// delete dentry with condition when objectlock is open
if objetLock != nil {
Expand All @@ -924,7 +924,7 @@ func (v *Volume) DeletePath(path string) (err error) {
deleteDentryCache(parent, name, v.name)
deleteAttrCache(parent, v.name)

log.LogWarnf("DeletePath: evict: volume(%v) path(%v) inode(%v)", v.name, path, ino)
log.LogInfof("DeletePath: evict: volume(%v) path(%v) inode(%v)", v.name, path, ino)
// Evict inode
if err = v.mw.Evict(ino); err != nil {
log.LogWarnf("DeletePath Evict: path(%v) inode(%v)", path, ino)
Expand Down

0 comments on commit b24525a

Please sign in to comment.