Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _mixins.scss #978

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Update _mixins.scss #978

merged 1 commit into from
Sep 9, 2024

Conversation

Rohit1415
Copy link
Contributor

@Rohit1415 Rohit1415 commented May 23, 2024

Removed outdated vendor prefixes: Modern browsers no longer need the -webkit-, -moz-, and -o- prefixes for linear-gradient, box-sizing, box-shadow, and border-radius. These properties are now well-supported without prefixes.
Retained filter for IE9: Kept the filter property for older versions of Internet Explorer.

Explanation:
slider-background-image: Sets a gradient background with a fallback for older versions of Internet Explorer. slider-box-sizing: Sets the box-sizing property.
slider-box-shadow: Sets the box-shadow property, allowing multiple values using the SCSS variadic arguments feature.

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
  • Link to original Github issue (if this is a bug-fix)
  • documentation updates to README file
  • examples within /tpl/index.tpl (for new options being added)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

Removed outdated vendor prefixes: Modern browsers no longer need the -webkit-, -moz-, and -o- prefixes for linear-gradient, box-sizing, box-shadow, and border-radius. These properties are now well-supported without prefixes.
Retained filter for IE9: Kept the filter property for older versions of Internet Explorer.

Explanation:
slider-background-image: Sets a gradient background with a fallback for older versions of Internet Explorer.
slider-box-sizing: Sets the box-sizing property.
slider-box-shadow: Sets the box-shadow property, allowing multiple values using the SCSS variadic arguments feature.
@utilmind utilmind merged commit 93c62a3 into seiyria:master Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants