Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the scale factor of container #974

Merged
merged 17 commits into from
Sep 8, 2024
Merged

Conversation

utilmind
Copy link
Collaborator

This is the fix for issue described several years ago in #625

To reproduce this issue, just scale the container of the Bootstrap Slider with CSS, set transform: scale(N), where N is different than 1 (increase or decrease size of the container and its entire content).

Also updated _toPercentage() method now has some size & speed optimizations.

@ae-gladkikh
Copy link

When will this correction be adopted?

@seiyria
Copy link
Owner

seiyria commented Aug 23, 2024

@ae-gladkikh I unfortunately do not have time to maintain this project. If you or anyone you know would like to maintain the package, I would be happy to add you/them as a maintainer!

@utilmind
Copy link
Collaborator Author

If you or anyone you know would like to maintain the package, I would be happy to add you/them as a maintainer!

@seiyria, Add me as maintainer. I don't have time too, but I can do a code review and approve good improvements. Still better than nothing!

@utilmind
Copy link
Collaborator Author

@seiyria Actually I just saw invitation. Thanks for inviting! Accepted.

@seiyria
Copy link
Owner

seiyria commented Aug 23, 2024

You're welcome @utilmind - thank you for offering to help out! We really appreciate it!

@utilmind
Copy link
Collaborator Author

utilmind commented Aug 23, 2024

Figuring out failed tests, reading rules...

Anyway going to approve this improvement. It was successfully used in multiple projects during last 2 years.
Just couple of demos (both have no issues with scale factor on page):

  1. https://utilmind.com/demos/2022/emotion-picker/
  2. https://pro-pursuit.com/

UPD. Still can't build this project on my local environment. But determined to figure everything out and finally make a new release.

@utilmind
Copy link
Collaborator Author

utilmind commented Sep 8, 2024

Sorry, I still can't figure out how to pass the tests or how to modify them with my existing privileges (I don't have access to Netlify).

Although I have successfully built the package on my local environment with some changes. I had to stop using Grunt and Jasmine and it's probably not good... Probably the only option to me is to maintain the fork in the future, although it will be w/o tests anyway...

UPD. I will do more attempts later... Not sure whether I'm able to fix something on Netlify...

@utilmind
Copy link
Collaborator Author

utilmind commented Sep 8, 2024

Ok, was able to pass checks after upgrading NPM version, but build preview seems not good... Digging further...

@utilmind utilmind merged commit 186b1f6 into seiyria:master Sep 8, 2024
4 checks passed
@utilmind
Copy link
Collaborator Author

utilmind commented Sep 8, 2024

Yay!

@utilmind
Copy link
Collaborator Author

utilmind commented Sep 8, 2024

When will this correction be adopted?

@ae-gladkikh Done. Please test it and let me know if you will have any issues.
(This is my first merge here, so despite I hope that everything will be fine, issues are possible.)

@utilmind
Copy link
Collaborator Author

utilmind commented Sep 9, 2024

For some reason "dist" folder doesn't contain updated packages. I thought that Netlify supposed to build it automatically... :-/
I'll figure this out and update files in "dist" ASAP.

@ae-gladkikh
Copy link

When will this correction be adopted?

@ae-gladkikh Done. Please test it and let me know if you will have any issues. (This is my first merge here, so despite I hope that everything will be fine, issues are possible.)

Good news, i will test ASAP

@utilmind
Copy link
Collaborator Author

utilmind commented Sep 9, 2024

@ae-gladkikh now really released, files in "dist" folder updated.

(It turns out that it's not fully automated, the script that prepares the release should be run manually. Anyway, it's ready now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants