Regenerated and removed unnecessary flag from build script command #202
Conversation
|
- Switched build script and other npm scripts to generate before deploying - Changed the names of directories for clarity (protoc are buf generated files, library is the uncompiled ts code that will be in the npm package, dist will be the part hosted on npm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 84.47% 4.67% -79.80%
==========================================
Files 16 212 +196
Lines 161 44030 +43869
Branches 25 15793 +15768
==========================================
+ Hits 136 2058 +1922
- Misses 25 41972 +41947 ☔ View full report in Codecov by Sentry. |
| @@ -18,6 +18,8 @@ jobs: | |||
| steps: | |||
| - name: Check out code | |||
| uses: actions/checkout@v2 | |||
| with: | |||
| fetch-depth: 0 # Fetch the full history instead of a shallow clone | |||
There was a problem hiding this comment.
Curious why we need this here
There was a problem hiding this comment.
Can see why it's needed in release.yml since it deals with changesets and tags, but not sure about this workflow
| @@ -30,7 +30,8 @@ jobs: | |||
| steps: | |||
| - name: Checkout Repo | |||
| uses: actions/checkout@v3 | |||
|
|
|||
| with: | |||
| fetch-depth: 0 # Fetch the full history instead of a shallow clone | |||
There was a problem hiding this comment.
Also can't tell why this is needed here
This PR fixes some build issues introduced into the system with the latest @sei-js/cosmos release. This PR adjusts the directories for readability and clarity, removes the protobuf generation step from the github action, and does other general package cleanup.