Bindings for getting EVM address by Sei address and vice versa #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besated
reviewed
Apr 8, 2024
| deps: Deps<SeiQueryWrapper>, | ||
| evm_address: String, | ||
| ) -> StdResult<SeiAddressResponse> { | ||
| let querier = SeiQuerier::new(&deps.querier); |
There was a problem hiding this comment.
is there a way to validate the evm_address similar to how we validate the sei_address above?
There was a problem hiding this comment.
also should this be moved into the package itself as opposed to being in the tester contract?
There was a problem hiding this comment.
Discussed offline. TL;DR The library that I have tried ethaddr had to be rolledback due to unstable keccak dep. We may move validations down to lib itself in subsequent PRs (and add them all over to keep the code consistent)
codchen
approved these changes
Apr 9, 2024
dssei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding bindings for getting EVM address by Sei address and vice versa.
Building on top of sei-protocol/sei-chain#1466
Testing