Add EVM query/msg types #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, looking good! One thing to ask, before it was mentioned to me that the reason why the ERC20/721 queries existed was because they where also helpers that translated sei addresses to 0x addresses. For anyone else looking at the crates documentation, that functionality won't be immediately obvious. Do all of the "address" String fields take sei* or 0x* addresses? The answer isn't clearly communicated right now and we shouldn't have to look at the go source code to understand how we should utilize this. |
dssei
reviewed
Mar 28, 2024
| } | ||
| ExecuteMsg::TestOccIteratorRange { start, end } => { | ||
| test_occ_iterator_range(deps, env, info, start, end) | ||
| } | ||
| ExecuteMsg::TestOccParallelism { value } => test_occ_parallelism(deps, env, info, value), |
There was a problem hiding this comment.
Curious if there are plans to also add tests for new evm functionality (and possibly extend the integration module)?
|
We may also need to update this readme |
dssei
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add query/message support for evm bindings