Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS Only Write Leaf Nodes #548

Merged
merged 1 commit into from
Nov 1, 2024
Merged

SS Only Write Leaf Nodes #548

merged 1 commit into from
Nov 1, 2024

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Nov 1, 2024

Describe your changes and provide context

  • Only write iavl leaf nodes to ss during initial sc migration
  • This was removed previously incorrectly

Testing performed to validate your change

  • Testing on rpc migration node

@Kbhat1 Kbhat1 requested a review from yzang2019 November 1, 2024 11:08
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.89%. Comparing base (d3830c1) to head (4b42148).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
storev2/rootmulti/store.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         631      631           
  Lines       54954    54954           
=======================================
+ Hits        30165    30166    +1     
+ Misses      22631    22630    -1     
  Partials     2158     2158           
Files with missing lines Coverage Δ
storev2/rootmulti/store.go 2.60% <0.00%> (ø)

... and 1 file with indirect coverage changes

@Kbhat1 Kbhat1 merged commit 71ec704 into main Nov 1, 2024
14 of 15 checks passed
@Kbhat1 Kbhat1 deleted the SSRestoreUpdate branch November 1, 2024 11:20
Kbhat1 added a commit that referenced this pull request Nov 1, 2024
## Describe your changes and provide context
- Only write iavl leaf nodes to ss during initial sc migration
- This was removed previously incorrectly

## Testing performed to validate your change
- Testing on rpc migration node
Kbhat1 added a commit that referenced this pull request Nov 5, 2024
## Describe your changes and provide context
- Only write iavl leaf nodes to ss during initial sc migration
- This was removed previously incorrectly

## Testing performed to validate your change
- Testing on rpc migration node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants