New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] RPC simulation for high gas wanted txs #2069

Open

jewei1997 wants to merge 1 commit into main from rpc-simulation-high-gas-wanted

+146 −17

Contributor

jewei1997 commented Feb 7, 2025

Describe your changes and provide context

Testing performed to validate your change


          RPC simulation for high gas wantedtxs

cc0a7dd

github-advanced-security bot found potential problems

View reviewed changes

evmrpc/send.go

+              			return hash, err
+              		}
+              		fmt.Println("DEBUG: estimate = ", estimate)
+              		percentDiff := float64(estimate) / float64(tx.Gas())

Check notice

Code scanning / CodeQL

Floating point arithmetic Note

Floating point arithmetic operations are not associative and a possible source of non-determinism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet