Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist Pebble Hashes during scanner #2065

Merged
merged 13 commits into from
Feb 3, 2025
Merged

Persist Pebble Hashes during scanner #2065

merged 13 commits into from
Feb 3, 2025

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Jan 31, 2025

Describe your changes and provide context

  • Persist pebble hashes for the scanner to db itself as metadata

Testing performed to validate your change

  • Verified on seidb rpc node

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.51%. Comparing base (51f6572) to head (2aea2a7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/test_state_store.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2065   +/-   ##
=======================================
  Coverage   61.51%   61.51%           
=======================================
  Files         264      264           
  Lines       24630    24632    +2     
=======================================
+ Hits        15151    15153    +2     
- Misses       8348     8350    +2     
+ Partials     1131     1129    -2     
Files with missing lines Coverage Δ
app/test_state_store.go 55.69% <0.00%> (-0.46%) ⬇️

... and 2 files with indirect coverage changes

Base automatically changed from yzang/SEI-8920 to main February 1, 2025 04:11
@yzang2019 yzang2019 self-requested a review February 3, 2025 16:09
@Kbhat1 Kbhat1 enabled auto-merge (squash) February 3, 2025 16:53
@Kbhat1 Kbhat1 disabled auto-merge February 3, 2025 16:53
@Kbhat1 Kbhat1 merged commit 83d6980 into main Feb 3, 2025
48 of 49 checks passed
@Kbhat1 Kbhat1 deleted the BackfillPebbleHashes branch February 3, 2025 17:10
Kbhat1 added a commit that referenced this pull request Feb 3, 2025
* Add tools to scan and compute hash for IAVL db

* Fix lint

* Fix lint

* Fix

* Fix

* Fix

* Pebble scanner (#2061)

* Pebble scanner

* Update name

* Update command

* Persist hashes

* Update method

* add backfill flag

* Bump seidb

---------

Co-authored-by: yzang2019 <[email protected]>
Kbhat1 added a commit that referenced this pull request Feb 4, 2025
* Add tools to scan and compute hash for IAVL db

* Fix lint

* Fix lint

* Fix

* Fix

* Fix

* Pebble scanner (#2061)

* Pebble scanner

* Update name

* Update command

* Persist hashes

* Update method

* add backfill flag

* Bump seidb

---------

Co-authored-by: yzang2019 <[email protected]>
Kbhat1 added a commit that referenced this pull request Feb 5, 2025
* Add tools to scan and compute hash for IAVL db

* Fix lint

* Fix lint

* Fix

* Fix

* Fix

* Pebble scanner (#2061)

* Pebble scanner

* Update name

* Update command

* Persist hashes

* Update method

* add backfill flag

* Bump seidb

---------

Co-authored-by: yzang2019 <[email protected]>
Kbhat1 added a commit that referenced this pull request Feb 5, 2025
* Add tools to scan and compute hash for IAVL db

* Fix lint

* Fix lint

* Fix

* Fix

* Fix

* Pebble scanner (#2061)

* Pebble scanner

* Update name

* Update command

* Persist hashes

* Update method

* add backfill flag

* Bump seidb

---------

Co-authored-by: yzang2019 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants