Add tools to scan and compute hash for IAVL db #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
56
to
68
| go func(index int, data chan types.RawSnapshotNode) { | ||
| defer wg.Done() | ||
| var hashResult []byte | ||
| for item := range subsetChan { | ||
| entryHash := x.HashSingle(Serialize(item)) | ||
| if hashResult == nil { | ||
| hashResult = entryHash | ||
| } else { | ||
| hashResult = x.HashTwo(hashResult, entryHash) | ||
| } | ||
| } | ||
| allHashes[i] = hashResult | ||
| }(i, subsetChan) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Comment on lines
+46
to
+78
| go func() { | ||
| prefixDB := dbm.NewPrefixDB(s.db, []byte(utils.BuildRawPrefix(module))) | ||
| itr, err := prefixDB.Iterator(nil, nil) | ||
| count := 0 | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to create iterator: %w", err)) | ||
| } | ||
| defer itr.Close() | ||
| for ; itr.Valid(); itr.Next() { | ||
| value := bytes.Clone(itr.Value()) | ||
| node, err := iavl.MakeNode(value) | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to parse iavl node: %w", err)) | ||
| } | ||
|
|
||
| // Only scan leaf nodes | ||
| if node.GetHeight() != 0 { | ||
| continue | ||
| } | ||
| snapshotNode := types.RawSnapshotNode{ | ||
| StoreKey: module, | ||
| Key: node.GetNodeKey(), | ||
| Value: node.GetValue(), | ||
| Version: node.GetVersion(), | ||
| } | ||
| dataCh <- snapshotNode | ||
| count++ | ||
| if count%1000000 == 0 { | ||
| fmt.Printf("Scanned %d items for module %s\n", count, module) | ||
| } | ||
| } | ||
| close(dataCh) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2059 +/- ##
==========================================
- Coverage 61.47% 61.35% -0.12%
==========================================
Files 264 264
Lines 24608 24630 +22
==========================================
- Hits 15127 15111 -16
- Misses 8356 8391 +35
- Partials 1125 1128 +3 |
Kbhat1
approved these changes
Jan 31, 2025
* Pebble scanner * Update name * Update command
Comment on lines
+45
to
+66
| go func() { | ||
| count := 0 | ||
| _, err := s.db.RawIterate(module, func(key, value []byte, version int64) bool { | ||
| dataCh <- types.RawSnapshotNode{ | ||
| StoreKey: module, | ||
| Key: key, | ||
| Value: value, | ||
| Version: version, | ||
| } | ||
|
|
||
| count++ | ||
| if count%1000000 == 0 { | ||
| fmt.Printf("Scanned %d items for module %s\n", count, module) | ||
| } | ||
|
|
||
| return false | ||
| }) | ||
| if err != nil { | ||
| panic(fmt.Errorf("RawIterate error: %w", err)) | ||
| } | ||
| close(dataCh) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Kbhat1
added a commit
that referenced
this pull request
Feb 3, 2025
* Add tools to scan and compute hash for IAVL db * Fix lint * Fix lint * Fix * Fix * Fix * Pebble scanner (#2061) * Pebble scanner * Update name * Update command --------- Co-authored-by: Kartik Bhat <[email protected]>
Kbhat1
added a commit
that referenced
this pull request
Feb 4, 2025
* Add tools to scan and compute hash for IAVL db * Fix lint * Fix lint * Fix * Fix * Fix * Pebble scanner (#2061) * Pebble scanner * Update name * Update command --------- Co-authored-by: Kartik Bhat <[email protected]>
Kbhat1
added a commit
that referenced
this pull request
Feb 5, 2025
* Add tools to scan and compute hash for IAVL db * Fix lint * Fix lint * Fix * Fix * Fix * Pebble scanner (#2061) * Pebble scanner * Update name * Update command --------- Co-authored-by: Kartik Bhat <[email protected]>
Kbhat1
added a commit
that referenced
this pull request
Feb 5, 2025
* Add tools to scan and compute hash for IAVL db * Fix lint * Fix lint * Fix * Fix * Fix * Pebble scanner (#2061) * Pebble scanner * Update name * Update command --------- Co-authored-by: Kartik Bhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change