Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Synthetic txs from *ExcludePanicTx endpoints #2058

Merged

Conversation

jewei1997
Copy link
Contributor

@jewei1997 jewei1997 commented Jan 29, 2025

Describe your changes and provide context

Synthetic txs should not show up in the sei_*ExcludePanicTx endpoints.

Testing performed to validate your change

unit tests, integration tests, and manually tested on archive node on specific failure case

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 61.33%. Comparing base (3ca49df) to head (e48c22d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
evmrpc/tracers.go 0.00% 6 Missing ⚠️
evmrpc/block.go 76.92% 3 Missing ⚠️
evmrpc/server.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
- Coverage   61.39%   61.33%   -0.06%     
==========================================
  Files         264      264              
  Lines       24626    24632       +6     
==========================================
- Hits        15118    15108      -10     
- Misses       8372     8391      +19     
+ Partials     1136     1133       -3     
Files with missing lines Coverage Δ
evmrpc/server.go 86.82% <60.00%> (ø)
evmrpc/block.go 75.97% <76.92%> (-0.27%) ⬇️
evmrpc/tracers.go 59.22% <0.00%> (-3.03%) ⬇️

... and 2 files with indirect coverage changes

@jewei1997 jewei1997 requested a review from philipsu522 January 30, 2025 19:16
@jewei1997 jewei1997 merged commit 6788468 into main Jan 31, 2025
48 of 49 checks passed
@jewei1997 jewei1997 deleted the exclude-synthetic-txs-from-exclude-trace-fail-endpoints branch January 31, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants