-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Synthetic txs from *ExcludePanicTx endpoints #2058
Merged
jewei1997
merged 9 commits into
main
from
exclude-synthetic-txs-from-exclude-trace-fail-endpoints
Jan 31, 2025
Merged
Exclude Synthetic txs from *ExcludePanicTx endpoints #2058
jewei1997
merged 9 commits into
main
from
exclude-synthetic-txs-from-exclude-trace-fail-endpoints
Jan 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2058 +/- ##
==========================================
- Coverage 61.39% 61.33% -0.06%
==========================================
Files 264 264
Lines 24626 24632 +6
==========================================
- Hits 15118 15108 -10
- Misses 8372 8391 +19
+ Partials 1136 1133 -3
|
philipsu522
approved these changes
Jan 30, 2025
jewei1997
added a commit
that referenced
this pull request
Jan 31, 2025
philipsu522
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Synthetic txs should not show up in the sei_*ExcludePanicTx endpoints.
Testing performed to validate your change
unit tests, integration tests, and manually tested on archive node on specific failure case