-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extractAsBytesFromArray method for JSON precompile #2054
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2054 +/- ##
==========================================
- Coverage 61.50% 61.30% -0.20%
==========================================
Files 264 264
Lines 24593 24626 +33
==========================================
- Hits 15125 15098 -27
- Misses 8335 8395 +60
Partials 1133 1133
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might need migration handlers to properly roll this out
I see. Thought migration handlers are for modules related changes. Looked into similar PRs but have not seen any examples of handlers changes. Do you have one by any chance? |
yeah I think you can look at this PR as an example. Basically you need migration handlers to update the precompile contracts #2043 |
Describe your changes and provide context
extractAsBytesFromArray method for JSON precompile to allow elements extraction from JSON arrays.
This additional method is needed for cases like
We do have methods allowing extracting data by key or array(list) by key, but no way to extract element from array.
E.g. data.exchange_rates[0][0]
Testing performed to validate your change