Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract multiple EVM logs from a single WASM event #2050

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jan 22, 2025

Describe your changes and provide context

It is possible for a single WASM event to contain multiple actions, so we should be translating each action, instead of each WASM event, into individual EVM logs. This PR changes the translation logic as such.

Testing performed to validate your change

unit test

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 88.71595% with 29 lines in your changes missing coverage. Please review.

Project coverage is 61.36%. Comparing base (6788468) to head (d8e5e2f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/receipt.go 88.71% 16 Missing and 13 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2050      +/-   ##
==========================================
+ Coverage   61.34%   61.36%   +0.01%     
==========================================
  Files         264      264              
  Lines       24632    24573      -59     
==========================================
- Hits        15111    15079      -32     
+ Misses       8387     8374      -13     
+ Partials     1134     1120      -14     
Files with missing lines Coverage Δ
app/receipt.go 86.63% <88.71%> (+9.03%) ⬆️

... and 4 files with indirect coverage changes

@codchen codchen force-pushed the tony/extend-cw721-event-translation branch from ecdc64a to d8e5e2f Compare January 31, 2025 05:20
@codchen codchen merged commit 977be40 into main Jan 31, 2025
49 checks passed
@codchen codchen deleted the tony/extend-cw721-event-translation branch January 31, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants