Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ct to load test framework #1959

Merged
merged 12 commits into from
Dec 3, 2024
Merged

add ct to load test framework #1959

merged 12 commits into from
Dec 3, 2024

Conversation

dssei
Copy link
Contributor

@dssei dssei commented Nov 22, 2024

Describe your changes and provide context

Added 4 types of load tests for confidential transfers testing

Testing performed to validate your change

  • Ran loadtest cluster setup + performance testing

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.98%. Comparing base (81c0d5f) to head (8717c84).
Report is 43 commits behind head on feature/ct_types.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feature/ct_types    #1959      +/-   ##
====================================================
- Coverage             61.57%   59.98%   -1.60%     
====================================================
  Files                   263      283      +20     
  Lines                 23306    25880    +2574     
====================================================
+ Hits                  14351    15524    +1173     
- Misses                 7948     9220    +1272     
- Partials               1007     1136     +129     

see 3 files with indirect coverage changes

@dssei dssei marked this pull request as ready for review November 27, 2024 00:12
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@dssei dssei requested a review from mj850 December 2, 2024 23:16
Copy link
Contributor

@mj850 mj850 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Few questions though:

  1. Are we still using a flag in code to determine whether to run the ct module commands as part of the loadtest? If so, should we write a readme or TODO somewhere on where this is enabled?

  2. What process calls loadtest/scripts/populate_ct_accounts.py? Didn't see any mention of it

@dssei
Copy link
Contributor Author

dssei commented Dec 3, 2024

Looks good to me!

Few questions though:

  1. Are we still using a flag in code to determine whether to run the ct module commands as part of the loadtest? If so, should we write a readme or TODO somewhere on where this is enabled?

Not using flag anymore

  1. What process calls loadtest/scripts/populate_ct_accounts.py? Didn't see any mention of it

You would have to run that manually (added readme me in infra changes)

Infra changes here https://github.com/sei-protocol/sei-infra/pull/874

@dssei dssei merged commit d56d863 into feature/ct_types Dec 3, 2024
46 checks passed
@dssei dssei deleted the ct_load_test branch December 3, 2024 00:41
mj850 pushed a commit that referenced this pull request Dec 7, 2024
* add ct to load test framework

* comment out receiver account creation for now

* - add ct account population script
- add ct query client
- add 4 types of ct messages for load test

* - script updates

* - add error handling

* script updates

* formatting

* disable state writing for transfers

* add metrics

* Revert "add metrics"

This reverts commit a7814b1.

* self review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants