-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ct to load test framework #1959
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/ct_types #1959 +/- ##
====================================================
- Coverage 61.57% 59.98% -1.60%
====================================================
Files 263 283 +20
Lines 23306 25880 +2574
====================================================
+ Hits 14351 15524 +1173
- Misses 7948 9220 +1272
- Partials 1007 1136 +129 |
- add ct query client - add 4 types of ct messages for load test
…into ct_load_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This reverts commit a7814b1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Few questions though:
-
Are we still using a flag in code to determine whether to run the ct module commands as part of the loadtest? If so, should we write a readme or TODO somewhere on where this is enabled?
-
What process calls loadtest/scripts/populate_ct_accounts.py? Didn't see any mention of it
Not using flag anymore
You would have to run that manually (added readme me in infra changes) Infra changes here https://github.com/sei-protocol/sei-infra/pull/874 |
* add ct to load test framework * comment out receiver account creation for now * - add ct account population script - add ct query client - add 4 types of ct messages for load test * - script updates * - add error handling * script updates * formatting * disable state writing for transfers * add metrics * Revert "add metrics" This reverts commit a7814b1. * self review fixes
Describe your changes and provide context
Added 4 types of load tests for confidential transfers testing
Testing performed to validate your change