Assign owner correctly when there are multiple transfers #1956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
It is possible to have multiple ERC721 transfers in the same transaction. The previous implementation of owner replacement doesn't account for such scenarios and always use the last
pretransfer_owner
event to fill in owners for synthetic ERC721 events. This PR fixes it by assigningpretransfer_owner
event to the correct transfer event based on order of appearance.Testing performed to validate your change
unit test that involves multiple transfers in a tx