Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Queries to Iavl for Non-Migrating Nodes #1954

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Nov 20, 2024

Describe your changes and provide context

  • Allows running sc-migration and setting --migrate-height on a node
  • Queries before migrate height will be routed to iavl and after to seidb

Testing performed to validate your change

  • Tested and verified on a rpc node that ran sc migration and migrate height

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.50%. Comparing base (6730097) to head (ee9f0af).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/seidb.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
- Coverage   61.68%   61.50%   -0.18%     
==========================================
  Files         263      263              
  Lines       23394    23394              
==========================================
- Hits        14430    14388      -42     
- Misses       7959     8005      +46     
+ Partials     1005     1001       -4     
Files with missing lines Coverage Δ
app/seidb.go 80.35% <0.00%> (ø)

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@Kbhat1 Kbhat1 merged commit 1d657da into main Nov 20, 2024
50 of 52 checks passed
@Kbhat1 Kbhat1 deleted the MigrateHeightQueries branch November 20, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants