fix: complete failed transaction receipts with block data #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindchaser
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
+ Coverage 61.49% 61.69% +0.20%
==========================================
Files 263 263
Lines 23394 23425 +31
==========================================
+ Hits 14387 14453 +66
+ Misses 8006 7967 -39
- Partials 1001 1005 +4
|
jewei1997
approved these changes
Nov 20, 2024
blindchaser
force-pushed
the
yiren/v6.0.0-getTransactionReceipt-incomplete
branch
from
2342a98
to
3ee367a
Compare
blindchaser
force-pushed
the
yiren/v6.0.0-getTransactionReceipt-incomplete
branch
from
3ee367a
to
92a44bd
Compare
codchen
reviewed
Nov 21, 2024
evmrpc/tx.go
Outdated
| @@ -53,6 +53,44 @@ func (t *TransactionAPI) GetTransactionReceipt(ctx context.Context, hash common. | |||
| } | |||
| return nil, err | |||
| } | |||
| // Fill in the receipt if the transaction has failed and used 0 gas | |||
| if receipt.TxType == 0 && receipt.GasUsed == 0 { | |||
There was a problem hiding this comment.
should check status instead of txType
codchen
reviewed
Nov 21, 2024
| } | ||
| receipt.TxType = uint32(etx.Type()) | ||
| receipt.Status = uint32(ethtypes.ReceiptStatusFailed) | ||
| receipt.GasUsed = 0 |
There was a problem hiding this comment.
i think you can also fill other fields like input, value, etc. from etc
There was a problem hiding this comment.
it looks receipt doesn't have these fields: https://github.com/sei-protocol/sei-chain/blob/main/x/evm/types/receipt.pb.go#L102
i checked some successfully tx receipts, they have logs but it doesn't have input/value either.
jewei1997
reviewed
Nov 21, 2024
evmrpc/tx.go
Outdated
Comment on lines
56
to
57
| // Fill in the receipt if the transaction has failed and used 0 gas | ||
| if receipt.Status == 0 && receipt.GasUsed == 0 { |
There was a problem hiding this comment.
can you add a comment here saying that this case is for when a tx fails before it makes it to the VM?
philipsu522
deleted the
yiren/v6.0.0-getTransactionReceipt-incomplete
branch
philipsu522
pushed a commit
that referenced
this pull request
Nov 21, 2024
* feat: fill failed tx receipt missing fields with block data * improve logic * set gasUsed=0 * debug: gasUsed * remove log * fix status check * unit test * update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR enhances the handling of failed transaction receipts by filling in missing fields using data from the block. When a transaction fails with zero gas usage, the receipt might be missing important information. This PR ensures all receipt fields are properly populated by looking up the transaction in the block.
In
GetTransactionReceipt, when a receipt hasTxType == 0andGasUsed == 0, we:Testing performed to validate your change