Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1559: Add max base fee as a param #1951

Merged
merged 8 commits into from
Nov 22, 2024
Merged

EIP-1559: Add max base fee as a param #1951

merged 8 commits into from
Nov 22, 2024

Conversation

jewei1997
Copy link
Contributor

@jewei1997 jewei1997 commented Nov 20, 2024

Describe your changes and provide context

Introduce max base fee (as opposed to max base fee) as param that can adjusted with a gov proposal. Will set to 1,000gwei for now.

Testing performed to validate your change

added unit tests.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 61.67%. Comparing base (bf789f3) to head (6762fb0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/types/params.go 30.76% 6 Missing and 3 partials ⚠️
x/evm/migrations/migrate_eip_1559_max_base_fee.go 0.00% 5 Missing ⚠️
x/evm/module.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
- Coverage   61.78%   61.67%   -0.11%     
==========================================
  Files         263      264       +1     
  Lines       23447    23473      +26     
==========================================
- Hits        14486    14477       -9     
- Misses       7956     7988      +32     
- Partials     1005     1008       +3     
Files with missing lines Coverage Δ
app/eth_replay.go 0.00% <ø> (ø)
x/evm/keeper/fee.go 88.33% <100.00%> (+0.83%) ⬆️
x/evm/keeper/params.go 82.92% <100.00%> (+0.87%) ⬆️
x/evm/module.go 40.00% <0.00%> (-0.61%) ⬇️
x/evm/migrations/migrate_eip_1559_max_base_fee.go 0.00% <0.00%> (ø)
x/evm/types/params.go 69.49% <30.76%> (-4.80%) ⬇️

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@jewei1997 jewei1997 enabled auto-merge (squash) November 22, 2024 19:17
@jewei1997 jewei1997 merged commit 3807a81 into main Nov 22, 2024
48 of 49 checks passed
@jewei1997 jewei1997 deleted the eip-1559-max-base-fee branch November 22, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants