bug fix: Be resilient to failing txs in debug trace block [main] #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1949 +/- ##
==========================================
+ Coverage 61.38% 61.63% +0.25%
==========================================
Files 263 263
Lines 23356 23355 -1
==========================================
+ Hits 14337 14395 +58
+ Misses 8015 7955 -60
- Partials 1004 1005 +1
|
codchen
approved these changes
Nov 20, 2024
jewei1997
deleted the
jeremy-hotfix-trace-block-resilient-to-tx-errs/main
branch
philipsu522
pushed a commit
that referenced
this pull request
Nov 21, 2024
* trace block resilient to tx errs * fix geth deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
geth changes: sei-protocol/go-ethereum#36
fixes:
The #1943 "address 0xxxx is not linked" issue is caused by not being able to retrieve the previous/parent block's statedb due to an association error. Instead of just erroring out completely, we want to still try our best to return a statedb for the parent block to run debug trace blocks on the current block.
The #1944 "Nonce too low" issue is caused when a tx in the current block is not able to be traced. In this situation, we want to just skip over this tx and continue to trace other txs in the same block instead of erroring out completely.
Testing performed to validate your change
existing tests + manual testing on archive node