Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trace block resilient to individual trace tx errors #1945

Closed
wants to merge 1 commit into from

Conversation

jewei1997
Copy link
Contributor

@jewei1997 jewei1997 commented Nov 18, 2024

Describe your changes and provide context

Currently if there's a single tx in a block that errors, the debug trace block endpoint for the entire block will error out. This PR just captures the errors in the trace for the failing txs in the output along with any successful tx traces instead of just completely erroring out.

Fixes issue: #1943
geth change PR: sei-protocol/go-ethereum#36

Testing performed to validate your change

existing tests.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.66%. Comparing base (de63e75) to head (e1a59c1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
+ Coverage   61.38%   61.66%   +0.27%     
==========================================
  Files         263      263              
  Lines       23356    23356              
==========================================
+ Hits        14337    14402      +65     
+ Misses       8015     7949      -66     
- Partials     1004     1005       +1     

see 4 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant