Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: eth_getLogs missing events from early return #1941

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

jewei1997
Copy link
Contributor

@jewei1997 jewei1997 commented Nov 16, 2024

Describe your changes and provide context

Fixes this issue: #1934

This PR fixes the case where there's a block with a synthetic tx followed by a normal evm tx, we would do an early return and skip the normal evm tx logs in the eth_getLogs endpoint. Instead, what we should do is simply skip the synthetic tx and return any normal evm logs later on in the block.

Testing performed to validate your change

unit tests.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.57%. Comparing base (47a578b) to head (6296b52).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
- Coverage   61.58%   61.57%   -0.02%     
==========================================
  Files         263      263              
  Lines       23359    23356       -3     
==========================================
- Hits        14386    14381       -5     
- Misses       7964     7969       +5     
+ Partials     1009     1006       -3     
Files with missing lines Coverage Δ
evmrpc/filter.go 78.03% <100.00%> (+1.62%) ⬆️

... and 4 files with indirect coverage changes

@jewei1997 jewei1997 merged commit de63e75 into main Nov 17, 2024
50 checks passed
@jewei1997 jewei1997 deleted the eth-logs-missing-events-main branch November 17, 2024 13:55
jewei1997 added a commit that referenced this pull request Nov 17, 2024
bug fix: eth_getLogs missing events from early return
#1941
philipsu522 pushed a commit that referenced this pull request Nov 18, 2024
* change return for EffectiveGas=0 to continue

* simplify

* add a unit test

* cleanup

* cleanup
philipsu522 pushed a commit that referenced this pull request Nov 18, 2024
* change return for EffectiveGas=0 to continue

* simplify

* add a unit test

* cleanup

* cleanup
philipsu522 pushed a commit that referenced this pull request Nov 21, 2024
* change return for EffectiveGas=0 to continue

* simplify

* add a unit test

* cleanup

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants