-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix: eth_getLogs missing events from early return #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1941 +/- ##
==========================================
- Coverage 61.58% 61.57% -0.02%
==========================================
Files 263 263
Lines 23359 23356 -3
==========================================
- Hits 14386 14381 -5
- Misses 7964 7969 +5
+ Partials 1009 1006 -3
|
philipsu522
approved these changes
Nov 17, 2024
jewei1997
added a commit
that referenced
this pull request
Nov 17, 2024
bug fix: eth_getLogs missing events from early return #1941
philipsu522
pushed a commit
that referenced
this pull request
Nov 18, 2024
* change return for EffectiveGas=0 to continue * simplify * add a unit test * cleanup * cleanup
philipsu522
pushed a commit
that referenced
this pull request
Nov 18, 2024
* change return for EffectiveGas=0 to continue * simplify * add a unit test * cleanup * cleanup
philipsu522
pushed a commit
that referenced
this pull request
Nov 21, 2024
* change return for EffectiveGas=0 to continue * simplify * add a unit test * cleanup * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Fixes this issue: #1934
This PR fixes the case where there's a block with a synthetic tx followed by a normal evm tx, we would do an early return and skip the normal evm tx logs in the eth_getLogs endpoint. Instead, what we should do is simply skip the synthetic tx and return any normal evm logs later on in the block.
Testing performed to validate your change
unit tests.