Add confidential transfer queries to seid #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dssei
reviewed
Nov 14, 2024
|
lgtm. Similarly (to another cli pr), let's add tests where possible |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dssei
reviewed
Nov 14, 2024
| Short: "Query the account state", | ||
| Long: "Queries the account state associated with the address and denom." + | ||
| "Pass the --from flag to decrypt the account." + | ||
| "Pass the --decryptAvailableBalance flag to attempt to decrypt the available balance.", |
There was a problem hiding this comment.
usually multi word flags I think are concatenated with - e.g.
--decrypt-available-balance
There was a problem hiding this comment.
changed to --decrypt-available-balance
dssei
reviewed
Nov 14, 2024
| "Pass the --from flag to decrypt the account." + | ||
| "Pass the --decryptAvailableBalance flag to attempt to decrypt the available balance.", | ||
| Args: cobra.ExactArgs(2), | ||
| RunE: func(cmd *cobra.Command, args []string) error { |
There was a problem hiding this comment.
nit: I think we were moving those functions to separate methods in tx. Might make our code consistent
There was a problem hiding this comment.
Moved to separate functions for both
dssei
reviewed
Nov 14, 2024
dssei
reviewed
Nov 14, 2024
dssei
reviewed
Nov 14, 2024
dssei
reviewed
Nov 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/ct_types #1931 +/- ##
====================================================
- Coverage 61.36% 60.12% -1.24%
====================================================
Files 263 280 +17
Lines 23306 25290 +1984
====================================================
+ Hits 14301 15206 +905
- Misses 8001 8951 +950
- Partials 1004 1133 +129
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR adds seid queries for the confidential transfers module.
Testing performed to validate your change