Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor bank/oracle precompile to use dynamic gas #1926

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Nov 11, 2024

Describe your changes and provide context

For functions that involve iterators, we need to use dynamic gas. At the moment, bank and oracle are the two precompiles affected.

Testing performed to validate your change

unit test

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 61.45%. Comparing base (de63e75) to head (fbe7a79).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
precompiles/bank/bank.go 58.82% 28 Missing ⚠️
precompiles/oracle/oracle.go 68.75% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1926      +/-   ##
==========================================
+ Coverage   61.38%   61.45%   +0.06%     
==========================================
  Files         263      263              
  Lines       23356    23373      +17     
==========================================
+ Hits        14337    14363      +26     
+ Misses       8015     8010       -5     
+ Partials     1004     1000       -4     
Files with missing lines Coverage Δ
app/app.go 66.14% <100.00%> (ø)
precompiles/common/precompiles.go 51.82% <100.00%> (ø)
x/evm/keeper/evm.go 69.48% <100.00%> (+1.29%) ⬆️
precompiles/oracle/oracle.go 66.66% <68.75%> (+2.38%) ⬆️
precompiles/bank/bank.go 60.72% <58.82%> (+4.31%) ⬆️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@codchen codchen force-pushed the bank-precompile-dynamic-gas branch 17 times, most recently from 90902e0 to 64b8020 Compare November 12, 2024 11:59
@codchen codchen merged commit d5a2f2d into main Nov 20, 2024
49 checks passed
@codchen codchen deleted the bank-precompile-dynamic-gas branch November 20, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants