Fix amino registry for custom modules #1889
Conversation
| cdc.RegisterConcrete(&MsgCreateDenom{}, "tokenfactory/MsgCreateDenom", nil) | ||
| cdc.RegisterConcrete(&MsgMint{}, "tokenfactory/MsgMint", nil) | ||
| cdc.RegisterConcrete(&MsgBurn{}, "tokenfactory/MsgBurn", nil) | ||
| cdc.RegisterConcrete(&MsgChangeAdmin{}, "tokenfactory/MsgChangeAdmin", nil) |
There was a problem hiding this comment.
We are missing tokenfactory/MsgUpdateDenom it seems
| cdc.RegisterConcrete(&MsgSend{}, "evm/MsgSend", nil) | ||
| cdc.RegisterConcrete(&MsgRegisterPointer{}, "evm/MsgRegisterPointer", nil) | ||
| cdc.RegisterConcrete(&MsgAssociateContractAddress{}, "evm/MsgAssociateContractAddress", nil) | ||
| } |
There was a problem hiding this comment.
Missing MsgInternalEVMDelegateCall and MsgInternalEVMCall
There was a problem hiding this comment.
internal calls can only come from smart contract calls like cosmwasm right? If so they can't be called this way, right? adding them here anyways but not sure if itll make a difference?
There was a problem hiding this comment.
actually, yeah I dont think we should include this since its not intended to be user facing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1889 +/- ##
==========================================
+ Coverage 61.28% 61.34% +0.05%
==========================================
Files 263 263
Lines 23285 23310 +25
==========================================
+ Hits 14271 14299 +28
+ Misses 8006 8002 -4
- Partials 1008 1009 +1
|
Describe your changes and provide context
This modifies the way the amino codec is used for custom modules to verify signatures. This will allow our custom modules to properly be amino signed and verified.
Testing performed to validate your change
Local chain testing