Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eip-1559 default values #1888

Merged
merged 12 commits into from
Oct 4, 2024
Merged

Eip-1559 default values #1888

merged 12 commits into from
Oct 4, 2024

Conversation

jewei1997
Copy link
Contributor

@jewei1997 jewei1997 commented Oct 3, 2024

Describe your changes and provide context

Set Eip-1559 default values based on param tuning doc

Testing performed to validate your change

existing tests

@jewei1997 jewei1997 changed the title Eip 1559 default numbers Eip 1559 default values Oct 3, 2024
@jewei1997 jewei1997 changed the title Eip 1559 default values Eip-1559 default values Oct 3, 2024
@jewei1997 jewei1997 requested a review from codchen October 3, 2024 13:48
Copy link
Collaborator

@codchen codchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need a gov proposal to actual update these for the existing networks

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.29%. Comparing base (4a64247) to head (491c3fa).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
- Coverage   61.32%   61.29%   -0.03%     
==========================================
  Files         263      263              
  Lines       23310    23310              
==========================================
- Hits        14294    14289       -5     
- Misses       8008     8012       +4     
- Partials     1008     1009       +1     
Files with missing lines Coverage Δ
x/evm/types/params.go 69.49% <ø> (ø)

... and 2 files with indirect coverage changes

@jewei1997 jewei1997 merged commit 4daa00c into main Oct 4, 2024
49 checks passed
@jewei1997 jewei1997 deleted the eip-1559-default-numbers branch October 4, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants