[main branch] Exclude only shell receipts from eth endpoints #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewei1997
changed the title
jewei1997
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
- Coverage 61.26% 61.23% -0.03%
==========================================
Files 263 263
Lines 23272 23275 +3
==========================================
- Hits 14257 14253 -4
- Misses 8010 8014 +4
- Partials 1005 1008 +3
|
philipsu522
reviewed
Oct 1, 2024
Comment on lines
+133
to
+134
| expect(ethReceipts.length).to.equal(1); | ||
| expect(seiReceipts.length).to.equal(1); |
There was a problem hiding this comment.
do we do any verification on the seiReceipt?
There was a problem hiding this comment.
checking that the 2 tx hashes are the same between ethReceipts and seiReceipts
philipsu522
approved these changes
Oct 1, 2024
jewei1997
deleted the
exclude-only-shell-receipts-from-eth-endpoints-main
branch
jewei1997
added a commit
that referenced
this pull request
Oct 1, 2024
* exclude only shell receipts from eth endpoints * minor fix * remove print statements * put panic to see if shell receipts are being used * fix test * fix block receipts test * Revert "put panic to see if shell receipts are being used" This reverts commit 1ea23fd. * minor fixes * check that ethReceipt and seiReceipt have the same tx hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
In the eth_ endpoints, we actually do want to include synthetic logs because these have replaced EVM logs for ERC20 and ERC721 transfer/approval events. We will just exclude shell txs in eth_ endpoints and include both in sei_ endpoints.
Testing performed to validate your change
hardhat tests