Eip-1559 - target block gas used as param #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
+ Coverage 61.24% 61.30% +0.06%
==========================================
Files 263 263
Lines 23246 23272 +26
==========================================
+ Hits 14237 14267 +30
+ Misses 8006 8000 -6
- Partials 1003 1005 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -285,7 +286,10 @@ | |||
| // EndBlock executes all ABCI EndBlock logic respective to the evm module. It | |||
| // returns no validator updates. | |||
| func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.ValidatorUpdate { | |||
| am.keeper.AdjustDynamicBaseFeePerGas(ctx, uint64(req.BlockGasUsed)) | |||
| newBaseFee := am.keeper.AdjustDynamicBaseFeePerGas(ctx, uint64(req.BlockGasUsed)) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
jewei1997
force-pushed
the
target-block-gas-used-as-param
branch
from
7f0bdb4 to
65b0852
Compare
jewei1997
commented
Sep 30, 2024
app/upgrades.go
Outdated
| @@ -110,6 +110,7 @@ var upgradesList = []string{ | |||
| "v5.7.4", | |||
| "v5.7.5", | |||
| "v5.8.0", | |||
| "v5.9.1-jeremy-eip-1559", | |||
There was a problem hiding this comment.
TODO: delete this, was just testing upgrade
codchen
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Introduce target block gas used as a param instead of just using block gas limit/2. This give us more flexibility to set target gas used independently from the block gas limit. Also, emits metrics for base fee.
Testing performed to validate your change
unit tests, tested on loadtest cluster with prometheus metrics