V5.8.0 hotfix 4 #1866
Merged
V5.8.0 hotfix 4 #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
reviewed
Sep 23, 2024
evmrpc/block.go
Outdated
| @@ -77,6 +75,31 @@ func (a *BlockAPI) GetBlockByHash(ctx context.Context, blockHash common.Hash, fu | |||
| func (a *BlockAPI) GetBlockByNumber(ctx context.Context, number rpc.BlockNumber, fullTx bool) (result map[string]interface{}, returnErr error) { | |||
| startTime := time.Now() | |||
| defer recordMetrics("eth_getBlockByNumber", a.connectionType, startTime, returnErr == nil) | |||
| if number == 0 { | |||
blindchaser
force-pushed
the
v5.8.0-hotfix-4
branch
from
fa2a54d
to
6082a2d
Compare
yzang2019
approved these changes
Sep 23, 2024
philipsu522
approved these changes
Sep 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
- Coverage 61.64% 61.22% -0.43%
==========================================
Files 365 261 -104
Lines 26178 23152 -3026
==========================================
- Hits 16138 14174 -1964
+ Misses 8967 7978 -989
+ Partials 1073 1000 -73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change