Archive Node Online Migration #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return fmt.Errorf("failed to create iterator: %w", err) | ||
| } | ||
| defer itr.Close() | ||
|
|
||
| startTimeBatch := time.Now() // Measure time for every 10,000 iterations |
Check warning
Code scanning / CodeQL
Calling the system time Warning
yzang2019
approved these changes
Sep 18, 2024
yzang2019
reviewed
Sep 24, 2024
Kbhat1
force-pushed
the
ArchiveNodeMigrationOnline
branch
from
7ba74d6
to
27a1676
Compare
* Add QMS for online migration * Fix lint --------- Co-authored-by: kbhat1 <[email protected]>
Comment on lines
+311
to
+319
| go func() { | ||
| homeDir := cast.ToString(appOpts.Get(flags.FlagHome)) | ||
| stateStore := app.GetStateStore() | ||
| migrationHeight := cast.ToInt64(appOpts.Get("migrate-height")) | ||
| migrator := ss.NewMigrator(homeDir, db, stateStore) | ||
| if err := migrator.Migrate(migrationHeight, homeDir); err != nil { | ||
| panic(err) | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
- Coverage 61.56% 61.35% -0.22%
==========================================
Files 263 263
Lines 23308 23328 +20
==========================================
- Hits 14349 14312 -37
- Misses 7952 8013 +61
+ Partials 1007 1003 -4
|
| if module != startModule && startModule != "" { | ||
| continue | ||
| } | ||
| startTimeModule := time.Now() // Measure time for each module |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| }) | ||
|
|
||
| batchLeafNodeCount = 0 | ||
| startTimeBatch = time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
yzang2019
reviewed
Oct 17, 2024
yzang2019
reviewed
Oct 29, 2024
| fmt.Println("Scanning database and exporting leaf nodes...") | ||
| fmt.Println("SeiDB Archive Migration: Scanning database and exporting leaf nodes...") | ||
|
|
||
| startTimeTotal := time.Now() // Start measuring total time |
Check warning
Code scanning / CodeQL
Calling the system time Warning
yzang2019
reviewed
Oct 30, 2024
philipsu522
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Archive Node Online Migration * Add migrate-iavl flag for online migration * Update sei cosmos * Add QMS for online migration (#1870) * Add QMS for online migration * Fix lint --------- Co-authored-by: kbhat1 <[email protected]> * Add migrate-height flag to start cmd * Bump seidb * Reduce logging * Archive Migration doc * Update form * Update * Export metric * latest height * Update start module logic * Remove migrate SS command * Enable ss store * Update archive node migration docs * More migration doc updates * Update metrics in readme * Merge main * Remove dex * Add Faq section * Add requirements section * Systemd instructions * Minor add to readme * Add more examples for migration height * Bump sei cosmos * Update error log * Update command sc migration background --------- Co-authored-by: Yiming Zang <[email protected]>
Kbhat1
added a commit
that referenced
this pull request
Nov 1, 2024
* Archive Node Online Migration * Add migrate-iavl flag for online migration * Update sei cosmos * Add QMS for online migration (#1870) * Add QMS for online migration * Fix lint --------- Co-authored-by: kbhat1 <[email protected]> * Add migrate-height flag to start cmd * Bump seidb * Reduce logging * Archive Migration doc * Update form * Update * Export metric * latest height * Update start module logic * Remove migrate SS command * Enable ss store * Update archive node migration docs * More migration doc updates * Update metrics in readme * Merge main * Remove dex * Add Faq section * Add requirements section * Systemd instructions * Minor add to readme * Add more examples for migration height * Bump sei cosmos * Update error log * Update command sc migration background --------- Co-authored-by: Yiming Zang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change