-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delegatecall flag to properly detect delegatecalls #1856
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
- Coverage 61.11% 61.07% -0.04%
==========================================
Files 261 261
Lines 23098 23100 +2
==========================================
- Hits 14116 14108 -8
- Misses 7986 7999 +13
+ Partials 996 993 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In wasmd precompile can we also change for ExecuteBatch
and Instantiate
? also can we change to use this flag for these precompiles?
- bank
- distribution
- gov
- ibc
- pointer
- staking
Describe your changes and provide context
Use an explicit flag in the precompile to detect a delegatecall which is set by the delegatecall opcode in go-ethereum.
Testing performed to validate your change
existing unit tests