-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1559 - Dynamic Base Fee #1843
Conversation
8cf6e2b
to
dcde85b
Compare
x/evm/keeper/evm.go
Outdated
@@ -34,6 +34,7 @@ func (k *Keeper) HandleInternalEVMCall(ctx sdk.Context, req *types.MsgInternalEV | |||
if err != nil { | |||
return nil, err | |||
} | |||
k.GetEVMAddressOrDefault(ctx, senderAddr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we duplicate this effort with the below line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a mistake--will remove
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
+ Coverage 61.20% 61.43% +0.22%
==========================================
Files 261 263 +2
Lines 23147 23246 +99
==========================================
+ Hits 14167 14281 +114
+ Misses 7980 7960 -20
- Partials 1000 1005 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This commit is broken!
Describe your changes and provide context
Implementation of a modified version of eip-1559. How it works is on every EndBlock, it will adjust the BaseFee based on the gas used in the current block. The target gas for the block is always half of the total block gas limit. There are 2 major ways our eip-1559 implementation diverges from Ethereum's:
MaxDynamicBaseFeeUpwardAdjustment
andMaxDynamicBaseFeeDownwardAdjustment
parameters. We don't want to just blindly use the 12.5% used by Ethereum because has different block times and block gas limits.Currently
MaxDynamicBaseFeeUpwardAdjustment
is set to 5% andMaxDynamicBaseFeeDownwardAdjustment
is set to 1%, which means that base fee will go up at most 5% on a completely full block and down 1% on a completely empty block and will go up/down proportionally for everything in between (if block gas used is exactly half full, base fee will remain constant)Testing performed to validate your change
unit tests
loadtest cluster under load and viewing changing gas prices