fix calculation for withdrawn rewards #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
force-pushed
the
tony/fix-calculation
branch
from
3d47a9c
to
5990598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Withdrawn results should be calculated as:
bank balance - (all principals - withdrawn principals - staked principals). However previously we use the sum ofVESTING_AMOUNTSasall principalswhich is incorrect becauseVESTING_AMOUNTSgets updated whenever we withdraw unlocked tokens. This PR changes the calculation to make use of an immutable field that representsall principals. It also fixes any affected contract state in the migration handler.Testing performed to validate your change
todo