Skip to content

Dotdigital/destination #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Dotdigital/destination #7671

wants to merge 7 commits into from

Conversation

sta1r
Copy link

@sta1r sta1r commented Jun 11, 2025

Proposed changes

Adds some documentation for our initial set of Dotdigital destinations in Segment.

Merge timing

  • ASAP once approved

@sta1r sta1r requested a review from a team as a code owner June 11, 2025 13:26
@sta1r sta1r requested a review from forstisabella June 11, 2025 13:26
@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Jun 11, 2025 •
edited
Loading

hi @forstisabella - FYI this Destination is currently in Private Beta, but we'd like to move to Public beta quickly.
Could you please let me know when the docs are ready to deploy?

forstisabella
forstisabella reviewed Jun 11, 2025
View reviewed changes
forstisabella
forstisabella reviewed Jun 11, 2025
View reviewed changes
src/connections/destinations/catalog/dotdigital/index.md Outdated
@@ -0,0 +1,37 @@
---
title: Dotdigital Destination
id:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joe-ayoub-segment once we get an ID we'll be g2g to deploy tomorrow, afaik

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to insert the id on your end guys, I’m on annual leave so may miss further comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @forstisabella the ID is 68370e58cb330586908573b7

forstisabella
forstisabella reviewed Jun 11, 2025
View reviewed changes
@forstisabella forstisabella added the new-integration Added a new source or destination label Jun 11, 2025
@joe-ayoub-segment
Copy link
Contributor

Can we deploy this on Tuesday please @forstisabella ? We're aiming to go to public beta then.

@forstisabella forstisabella changed the base branch from develop to master June 17, 2025 00:05
forstisabella
forstisabella reviewed Jun 17, 2025
View reviewed changes
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor comments and then we'll be good to ship!

sta1r and others added 2 commits June 18, 2025 09:54
@sta1r
Copy link
Author

sta1r commented Jun 18, 2025

@joe-ayoub-segment @forstisabella Back from leave, final changes in. I guess this means this is released next Tuesday now?

@joe-ayoub-segment
Copy link
Contributor

Hi @sta1r and @forstisabella can we make this live but not link it to the index page?
The Destination is in Private beta at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forstisabella forstisabella forstisabella left review comments

@joe-ayoub-segment joe-ayoub-segment Awaiting requested review from joe-ayoub-segment

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new-integration Added a new source or destination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sta1r @joe-ayoub-segment @forstisabella