Specifying which user IDs should be submitted for deletion #6777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I added a warning containing the following message:
"It's important to note that the userID required for deletion requests are the user IDs sent through your events according to the Segment Spec. In other words, the IDs under the userId fields specifically, not just any identifier."
I've had a few customers in the past complain that the documentation should be clearer on which userIDs should be submitted for deletion. They've usually written in because they used some sort of internal identifier or an email as the ID for deletion, when it should be the user ID per the Segment Spec. I wanted to add this warning in order to prevent this from happening in the future.
Merge timing
Related issues (optional)