-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logger: ensure compatibility with new log/slog package #1247
base: main
Are you sure you want to change the base?
Conversation
fb4d4da
to
42ab3c3
Compare
I've fixed everything with CircleCI except the linters; the error message on the linter is incomprehensible. |
The API for the logger changes only slightly and should continue to be backwards compatible for any existing code.
42ab3c3
to
960f8f5
Compare
@@ -1,13 +1,22 @@ | |||
module github.com/segmentio/kafka-go | |||
|
|||
go 1.15 | |||
go 1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a separate PR for upgrading the Go version. Since kafka-go is so widely used this will be a breaking change for some users and the more explicit we can make that the less of a surprise it will be to users
environment: | ||
KAFKA_VERSION: "0.10.1" | ||
docker: | ||
- image: circleci/golang | ||
- image: cimg/go:1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be best to test against the same Go version that is in our go.mod
file
If you'd prefer I can handle the Go version upgrade and linting fixes. Then this PR will just be the change you actually want to make. Let me know what's best for you |
Sure, if you have time that would be great. |
I'm not sure this compatibility makes sense - For example: Line 274 in ebca72e
Will cause the following to be logged when using the
|
The API for the logger changes only slightly and should continue to be backwards compatible for any existing code.