Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: skip reading from compacted records #1164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: skip reading from compacted records #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions message_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,19 @@ func (r *messageSetReader) readMessageV1(min int64, key readBytesFunc, val readB

func (r *messageSetReader) readMessageV2(_ int64, key readBytesFunc, val readBytesFunc) (
offset int64, lastOffset int64, timestamp int64, headers []Header, err error) {
if err = r.readHeader(); err != nil {
return
for r.count == 0 {
// Keep reading new headers since in some cases when compacted logs is enabled, the broker may
// return a record header without any record value since the record was compacted (header.count=0).
//
// Trying to read from this compacted record would cause wrong data read and panic on markRead() since
// the reader count is actually 0.
if err = r.readHeader(); err != nil {
return
}
// Keep this as an infinite loop since in case the batch ended up with a compacted record, it will throws EOF
// and will be handled in the caller scope (batch).
}

if r.count == int(r.header.v2.count) { // first time reading this set, so check for compression headers.
var codec CompressionCodec
if codec, err = r.header.compression(); err != nil {
Expand Down